ID
Severity
Status
Title 51 Findings
Location
C-01
CRITICAL
FIXED

The setImplementetion function is executed without authorization in NGOLisFactory

NGOLisFactory.sol
C-02
CRITICAL
FIXED

Withdrawal of more ETH from the protocol than returned by Lido in NGOLis

NGOLis.sol
C-03
CRITICAL
FIXED

Decrease in stETH balance due to slashing or penalties is not accounted for in NGOLis

NGOLis.sol
C-04
CRITICAL
FIXED

Rounding during division leads to accumulation of undistributed rewards on the contract in NGOLis

NGOLis.sol
C-05
CRITICAL
FIXED

Contract lock risk on initial stake in NGOLis

NGOLis.sol
C-06
CRITICAL
FIXED

Unrestricted withdrawal of small stETH/wstETH amounts in NGOLis

NGOLis.sol
M-01
MAJOR
FIXED

Underflow when attempting to withdraw asset from prevRewards in NGOLis

NGOLis.sol
M-02
MAJOR
FIXED

Incorrect update of lastNGOBalance in NGOLis

NGOLis.sol
M-03
MAJOR
FIXED

Risk of Zero Calculation for Low _ratio and _ngoAssets in NGOLis

NGOLis.sol
M-04
MAJOR
FIXED

Underflow occurring during validator slashing events in NGOLis

NGOLis.sol
M-05
MAJOR
FIXED

Unwithdrawable balance after withdrawal in NGOLis

NGOLis.sol
W-01
WARNING
FIXED

Possible to pass a zero _amount in NGOLis

NGOLis.sol
W-02
WARNING
FIXED

Inconsistency in the calculation of userTotalShareWithNgoReward and rewardToNgo in NGOLis

NGOLis.sol
W-03
WARNING
FIXED

User does not receive rewards for staking when shares == 0 in NGOLis

NGOLis.sol
W-04
WARNING
FIXED

Possible to receive a zero amount of shares when converting non-zero assets in NGOLis

NGOLis.sol
W-05
WARNING
FIXED

Proxy creation uses ERC1967Proxy instead of NGOLisProxy in NGOLisFactory

NGOLisFactory.sol
W-06
WARNING
FIXED

Function __ReentrancyGuard_init is not called during initialization in NGOLis

NGOLis.sol
W-07
WARNING
FIXED

Insufficient validation of the size of _amount for withdrawal requests in NGOLis

NGOLis.sol
W-08
WARNING
FIXED

Users cannot withdraw stuck funds from the contract in NGOLis

NGOLis.sol
W-09
WARNING
FIXED

Incorrect value in the WithdrawClaimed event in NGOLis

NGOLis.sol
W-10
WARNING
FIXED

StakeInfo is not updated during withdraw operations in NGOLis

NGOLis.sol
W-11
WARNING
FIXED

Equality of minimum values for different tokens wstEth and stEth in NGOLis

NGOLis.sol
W-12
WARNING
ACKNOWLEDGED

Zero ratio after rounding during division in NGOLis

NGOLis.sol
I-01
INFO
FIXED

Delay between reward distributions changes after contract initialization in NGOLis

NGOLis.sol
I-02
INFO
FIXED

Setting msg.sender instead of owner in the mapping ownerToNgo in NGOLisFactory

NGOLisFactory.sol
I-03
INFO
FIXED

Inconsistency in error notification methods in NGOLis

NGOLis.sol
I-04
INFO
FIXED

No _disableInitializers call in the constructor in NGOLis

NGOLis.sol
I-05
INFO
FIXED

Redundant storage of the totalAssets value in NGOLis

NGOLis.sol
I-06
INFO
FIXED

Suboptimal handling of storage variables in NGOLis

I-07
INFO
FIXED

No parameter validation in NGOLis

NGOLis.sol
I-08
INFO
FIXED

Interface not used in IAccountOracle.sol

IAccountOracle.sol
I-09
INFO
FIXED

Unused variable _prevRewards in NGOLis

NGOLis.sol
I-10
INFO
FIXED

Redundant check for unsigned value being negative in NGOLis

NGOLis.sol
I-11
INFO
FIXED

Balance calculation before checking for stake existence in NGOLis

NGOLis.sol
I-12
INFO
FIXED

Insufficient validation in the case of the very first stake in NGOLis

NGOLis.sol
I-13
INFO
FIXED

Event name in the specification is misleading in NGOLisFactory

NGOLisFactory.sol
I-14
INFO
FIXED

Similar code in identical functions in NGOLis

NGOLis.sol
I-15
INFO
FIXED

Transfer of zero _fee is possible in NGOLis

NGOLis.sol
I-16
INFO
FIXED

No setter parameter validation in NGOLis

NGOLis.sol
I-17
INFO
FIXED

Simultaneous use of uint and uint256 types

I-18
INFO
FIXED

Redundant increment operation in NGOLis

NGOLis.sol
I-19
INFO
FIXED

Suboptimal computation of user balance in NGOLis

NGOLis.sol
I-20
INFO
ACKNOWLEDGED

Missing functionality for mistaken tokens and ETH withdrawal in NGOLis

NGOLis.sol
I-21
INFO
FIXED

Unused contracts in NGOLis.sol, NGOLisFactory.sol

NGOLis.sol
NGOLisFactory.sol
I-22
INFO
FIXED

Unused error in NGOLis

NGOLis.sol
I-23
INFO
FIXED

Misleading variable name wstAmount instead of stAmount in NGOLis

NGOLis.sol
I-24
INFO
FIXED

Incorrect event parameter value wstEth instead of stEth in NGOLis

NGOLis.sol
I-25
INFO
FIXED

Inconsistent state variable naming style in NGOLis, NGOLisFactory

NGOLis.sol
NGOLisFactory.sol
I-26
INFO
FIXED

Missing event emissions in setters in NGOLis, NGOLisFactory

NGOLis.sol
NGOLisFactory.sol
I-27
INFO
FIXED

Missing parameter validation in NGOLis, NGOLisFactory

NGOLis.sol
NGOLisFactory.sol
I-28
INFO
FIXED

Setting msg.sender as owner during deployment in NGOLisFactory

NGOLisFactory.sol

Please select finding