Back

Altitude

6/16/2024Published
ID
Severity
Status
Title 37 Findings
Location
C-01
CRITICAL
FIXED

Withdrawal without considering loan interest creates bad debt in InterestToken

InterestToken.sol
M-01
MAJOR
NO ISSUE

Possible overflow in HarvestableManager

HarvestableManager.sol
M-02
MAJOR
FIXED

Zero debt size sets interestIndex to 0 permanently in InterestToken

InterestToken.sol
M-03
MAJOR
FIXED

Excessive debt repayment locks liquidation process in LiquidatableManager

LiquidatableManager.sol
M-04
MAJOR
ACKNOWLEDGED

Harvest profit deprivation due to resetting harvestJoiningBlock in HarvestableVaultV1

HarvestableVault.sol
M-05
MAJOR
FIXED

Absence of whitelist allows injection and distribution of "dirty" cryptocurrency in HarvestableManager

HarvestableManager.sol
M-06
MAJOR
NO ISSUE

migrationFee increases borrow without considering availableBorrow in GroomableManager

GroomableManager.sol
W-01
WARNING
ACKNOWLEDGED

Lack of functionality to withdraw stuck tokens

W-02
WARNING
FIXED

Non-zero balance with zero index in InterestToken

InterestToken.sol
W-03
WARNING
NO ISSUE

Reference price is set up externally in StrategyGenericPool

StrategyGenericPool.sol
W-04
WARNING
ACKNOWLEDGED

Possibility of complete withdrawal in case of farm loss in VaultCoreV1

VaultCore.sol
W-05
WARNING
FIXED

No _disableInitializers call in the constructor in VaultRegistryV1

VaultRegistry.sol
W-06
WARNING
FIXED

Incorrect farm mode disable condition in FarmModeDecisionMaker

FarmModeDecisionMaker.sol
W-07
WARNING
NO ISSUE

Insufficient reference price validation in StrategyGenericPool

StrategyGenericPool.sol
W-08
WARNING
FIXED

DEFAULT_ADMIN_ROLE is assigned to msg.sender during contracts deployment

VaultRegistry.sol
Ingress.sol
FarmModeDecisionMaker.sol
W-09
WARNING
ACKNOWLEDGED

Lack of EIP-165 interface support validation

W-10
WARNING
FIXED

Potential for duplicate token creation in TokensFactory

TokensFactory.sol
W-11
WARNING
ACKNOWLEDGED

Deposit limit check may cause transaction reversion in Ingress

Ingress.sol
W-12
WARNING
FIXED

increaseAllowance and decreaseAllowance not disabled in DebtToken

DebtToken.sol
W-13
WARNING
ACKNOWLEDGED

Lack of support for deflationary tokens in VaultCore

VaultCore.sol
VaultERC20.sol
W-14
WARNING
FIXED

Reassigned amountTotal value may bypass zero check in HarvestableManager

HarvestableManager.sol
W-15
WARNING
FIXED

No parameters validation

FarmModeDecisionMaker.sol
VaultRegistry.sol
VaultOperable.sol
FarmBuffer.sol
FarmModeVault.sol
I-01
INFO
ACKNOWLEDGED

Redundant _onlyVault function in InterestToken

InterestToken.sol
I-02
INFO
FIXED

Unused constant MATH_UNITS in InterestToken

InterestToken.sol
I-03
INFO
FIXED

Fee is charged on withdrawal in VaultCoreV1

VaultCore.sol
I-04
INFO
ACKNOWLEDGED

Variable can be immutable in FarmBufferStrategy

FarmBufferStrategy.sol
I-05
INFO
FIXED

Suboptimal reading of the harvestStorage.harvests.length variable from storage in HarvestableManager

HarvestableManager.sol
I-06
INFO
FIXED

Simplifying subtraction of commit.userHarvestUncommittedEarnings in HarvestableManager

HarvestableManager.sol
I-07
INFO
FIXED

Code duplication in HarvestableVaultV1, LiquidatableManager

LiquidatableManager.sol
HarvestableVault.sol
I-08
INFO
FIXED

Use ++i to save gas

I-09
INFO
FIXED

Int type initialization to zero is redundant

I-10
INFO
FIXED

Floating pragma

I-11
INFO
FIXED

Use += in CommitMath

CommitMath.sol
I-12
INFO
NO ISSUE

Manual price limit in HarvestableManager

HarvestableManager.sol
I-13
INFO
NO ISSUE

Double execution of setBalance logic in SnapshotableManager

SnapshotableManager.sol
I-14
INFO
FIXED

Missed error handling in HarvestableManager

HarvestableManager.sol
I-15
INFO
FIXED

Magic numbers

CommitMath.sol
HealthFactorCalculator.sol
RebalanceIncentivesController.sol
ConfigurableManager.sol
GroomableManager.sol
GroomableVault.sol
LiquidatableManager.sol
LiquidatableVault.sol
HarvestableManager.sol
HarvestableVault.sol
SnapshotableVault.sol
VaultCore.sol
VaultInitializer.sol
FarmModeDecisionMaker.sol

Please select finding