Privacy Pools v1

A dishonest prover can manipulate the proof in IsNum2Bits

Possible bypass of validation through invalid input for membership proof

Limitation of merkle tree for withdrawals in PrivacyPool

User de-anonymization risk

Unverified transaction inclusion in Step (PoI)

Lack of nullifier uniqueness check in Step (PoI)

Missing output commitment validation in Step (PoI)

Lack of sums validation in Step (PoI)

Partial transaction history acceptance in Step (PoI)

Fees may exceed the amount being sent in PrivacyPool

Deposit amount logic inconsistency

Replay attack vulnerability in PrivacyPool

Unchecked transfers in ERC20PrivacyPool

Actual token received amount isn't checked in ERC20PrivacyPool

Shielded transfers are possible in the system

Missing validation of the _maximumDepositAmount in PrivacyPool

Missing validations in PrivacyPool, ERC20PrivacyPool

Relayer address can be zero in ERC20PrivacyPool, ETHPrivacyPool

No minimal value of withdrawal in PrivacyPool

Floating pragma, experimental encoder in ETHPrivacyPool, ERC20PrivacyPool, PrivacyPool

Unused code in proofOfInnocence.circom

Usage of old Poseidon in proofOfInnocence.circom

Unused imports in Step (PoI)

Inefficient gas usage in MerkleTreeWithHistory

Use of custom errors for efficiency and improved information in MerkleTreeWithHistory

No need to explicitly initialize variables with default values

Redundant event emissions in PrivacyPool

Redundant storage padding in PrivacyPool

Complex require logic consumes more gas in PrivacyPool

Redundant condition in PrivacyPool

Inefficient use of storage in PrivacyPool