Back

Zunami Protocol v2 Reaudit 2

4/29/2024Published
ID
Severity
Status
Title 16 Findings
Location
C-01
CRITICAL
FIXED

Claiming rewards is blocked after liquidity removal in ERC4626StratBase

ERC4626StratBase.sol
M-01
MAJOR
FIXED

Tokens' rate is ignored in CrvUsdStakeDaoERC4626StratBase

CrvUsdStakeDaoERC4626StratBase.sol
W-01
WARNING
FIXED

Missing parameter validation

ZunEthOracle.sol
SdtOracle.sol
SellingCurveRewardManager2.sol
W-02
WARNING
FIXED

Missing route validation in TokenConverter

TokenConverter.sol
W-03
WARNING
NO ISSUE

Valuation result doesn't account for slippage in TokenConverter

TokenConverter.sol
I-01
INFO
FIXED

Require is used for error handling

SdtOracle.sol
ZunEthOracle.sol
SellingCurveRewardManager2.sol
ZunamiStratBase.sol
I-02
INFO
FIXED

Magic numbers

SdtOracle.sol
ERC4626StratBase.sol
TokenConverter.sol
I-03
INFO
FIXED

Inconsistent interface location in SdtOracle, ZunEthOracle

SdtOracle.sol
ZunEthOracle.sol
I-04
INFO
FIXED

Redundant imports in SellingCurveRewardManager2, TokenConverter

SellingCurveRewardManager2.sol
TokenConverter.sol
I-05
INFO
FIXED

Functions visibility not optimal in SellingCurveRewardManager2, TokenConverter

SellingCurveRewardManager2.sol
TokenConverter.sol
I-06
INFO
FIXED

Wrong naming in ZunEthOracle

ZunEthOracle.sol
I-07
INFO
FIXED

Constant type name style in CrvUsdStakeDaoERC4626StratBase

CrvUsdStakeDaoERC4626StratBase.sol
I-08
INFO
FIXED

Redundant variable in SdtOracle

SdtOracle.sol
I-09
INFO
FIXED

Confusing naming in SellingCurveRewardManager2

SellingCurveRewardManager2.sol
I-10
INFO
FIXED

Redundant cast in SellingCurveRewardManager2

SellingCurveRewardManager2.sol
I-11
INFO
FIXED

Cache array length outside of loop in TokenConverter

TokenConverter.sol

Please select finding