Fathom Vaults

Conversion of losses and fees into shares occurs after changing totalDebt in VaultPackage

Incompatibility with deflationary tokens

Parameter validation in VaultPackage

No validation for duplicate strategies in VaultPackage

Wrong rounding of lossesUserShare in VaultPackage

maxRedeem returns more shares than redeemable in VaultPackage

Using msg.sender instead of the dedicated sender parameter in VaultPackage

Redundant code in VaultPackage

Method can be front-runned to avoid loss in VaultPackage

Redundant code in VaultPackage

Redundant check for decimalsValue in VaultPackage

Use addition and subtraction assignement operators to improve code readability in VaultPackage

Naming can be improved in VaultStorage

Redundant _onlySelf function in BaseStrategy

No withdraw stuck tokens functionality in TokenizedStrategy, VaultPackage

Missing check that tend logic is implemented in TokenizedStrategy

Unused function in VaultPackage

Int type initialization to zero is redundant in VaultPackage

Redundant inheritance from the contract ReentrancyGuard in FactoryStorage

Possible to erroneously set a very long distribution period in Investor

Redundant сall to _maxDeposit function in VaultPackage

Checking assets for zero occurs after calling _maxDeposit in VaultPackage

Unnecessary prohibition on setting depositLimit equal to zero in VaultPackage

Increment to empty value in VaultPackage

No event about setting vaultPackage in FactoryPackage

No validation of the same vaultPackage address during installation in FactoryPackage

Immutable variable in the section for constants in BaseStrategy